Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if site.getuserbase() exists #247

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Check if site.getuserbase() exists #247

merged 1 commit into from
Oct 27, 2021

Conversation

jasongrout
Copy link
Member

Apparently virtualenv often does not have site.getuserbase(), so we check for its existence first.

Fixes #246

@jasongrout
Check if site.getuserbase() exists
067a230 
Apparently virtualenv often does not have site.getuserbase(), so we check for its existence first.

Fixes jupyter#246
@jasongrout jasongrout added this to the 4.9 milestone Oct 27, 2021
@blink1073 blink1073 added the bug label Oct 27, 2021
blink1073
blink1073 approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit be863e3 into jupyter:master Oct 27, 2021
@jasongrout
Copy link
Member Author

FYI, if this workaround doesn't do the job for virtualenv, perhaps this idea would work: NaleRaphael/codememo@eea6fa9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
4.9
Development

Successfully merging this pull request may close these issues.

ReadtheDocs failure with version 4.9.0
2 participants
@jasongrout @blink1073